[WFMP-269] Allow multiple deployments to be used for the package goal #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x object for deployments. https://issues.redhat.com/browse/WFMP-269 Signed-off-by: James R. Perkins <[email protected]>
|
Maybe it should be |
jfdenise
reviewed
Nov 28, 2024
| @@ -271,6 +279,22 @@ public class PackageServerMojo extends AbstractProvisionServerMojo { | |||
| @Parameter(alias = "bootable-jar-install-artifact-classifier", property = PropertyNames.BOOTABLE_JAR_INSTALL_CLASSIFIER, defaultValue = BootableJarSupport.BOOTABLE_SUFFIX) | |||
| private String bootableJarInstallArtifactClassifier; | |||
|
|
|||
| /** | |||
| * A list of the dependencies to include as deployments. The dependencies must be defined as dependencies in the | |||
There was a problem hiding this comment.
We should perhaps add the syntax of the dependency?
|
@jamezp , I like the dependencies in the name, this is what they are, no confusion with File path,... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #561
@jfdenise WDYT? The idea is you don't need include a deployment definition for each extra deployment. For example in the demo project, you'd simple add:
OR