Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Core Data error handling in WMFData tests #5044

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Improve Core Data error handling in WMFData tests #5044

merged 7 commits into from
Nov 7, 2024

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented Oct 31, 2024 •
edited
Loading

Phabricator: N/A

Notes

This PR attempts to improve our flaky Core Data tests in WMFData. For example.

Test Steps

  1. Ensure unit tests pass

Screenshots/Videos

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team October 31, 2024 21:23
mazevedofs
mazevedofs approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tests are working well

@mazevedofs mazevedofs merged commit bf1a92b into main Nov 7, 2024
4 checks passed
@mazevedofs mazevedofs deleted the improve-test-stability branch November 7, 2024 19:29
@tonisevener tonisevener mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs mazevedofs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonisevener @mazevedofs