Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Update feature announcement #5043

Merged
merged 12 commits into from
Nov 4, 2024
Merged

[YiR] Update feature announcement #5043

merged 12 commits into from
Nov 4, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T378507

Notes

  • Add optional background image to WMFFeatureAnnouncementView
  • Add background asset for YiR announcement

Test Steps

  1. Set your device to a valid region (Mexico or Italy)
  2. Fresh install the app and login
  3. Set the language to Italian or Spanish or English
  4. Go through articles and generate 6+ article views in the History tab.
  5. Go to developer settings and toggle on Year in Review feature flag.
  6. Run the app and background it on the explore feed
  7. Open the app again. You should see the modal.
  8. Fresh install the app again, repeat the previous steps
  9. Go to an article - if possible on iPad this time
  10. You should see the modal

@mazevedofs mazevedofs requested review from a team and tonisevener and removed request for a team October 31, 2024 15:46
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tonisevener tonisevener merged commit 4e8b347 into main Nov 4, 2024
4 checks passed
@tonisevener tonisevener deleted the update-announcement branch November 4, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants