Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image recommendations - Present gallery after tapping on image #4789

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T358910

Notes

This PR leans on the existing MediaListGalleryViewController to present the gallery view from Image Recommendations.

Test Steps

  1. On Staging, go to Image Recommendations
  2. Tap image (just a gray box for now)
  3. Confirm gallery launches. Dismiss gallery
  4. Tap Not sure
  5. Tap image again, confirm gallery launches with new image.

@tonisevener tonisevener requested review from a team and staykids and removed request for a team March 22, 2024 21:41
@staykids staykids self-assigned this Mar 27, 2024
@staykids staykids merged commit 6d3b7e5 into main Mar 27, 2024
4 checks passed
@staykids staykids deleted the T358910 branch March 27, 2024 20:29
@staykids staykids removed their assignment Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants