Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WikiProject banners within {{WikiProject banner shell}} #1

Open
siddharthvp opened this issue Aug 13, 2022 · 3 comments
Open

Add WikiProject banners within {{WikiProject banner shell}} #1

siddharthvp opened this issue Aug 13, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@siddharthvp
Copy link
Member

WikiProject banners should be added within {{WikiProject banner shell}} if it already exists. If it doesn't exist and 3 or more banners are being added, the shell should be added.

@siddharthvp siddharthvp added the enhancement New feature or request label Aug 13, 2022
@NovemLinguae
Copy link
Member

This script creates drafts from scratch only, correct? It doesn't edit pre-existing drafts?

Then I wonder why prepareTalkText(initialText) has an initialText param?

The algorithm for fixing WikiProject banners and shells is MUCH more complicated than the algorithm for just adding them. So I want to double check before I decide what approach to take to solve this ticket.

@siddharthvp, any thoughts? Thank you.

@siddharthvp
Copy link
Member Author

@NovemLinguae It only edits pre-existing drafts 🙃 - since this script is for submitting drafts, not creating them.

@NovemLinguae
Copy link
Member

NovemLinguae commented Aug 31, 2024

Note to self when I work on this patch in the future: just copy and adapt the following AFCH code.

https://github.com/wikimedia-gadgets/afc-helper/blob/88c61247663de8304d2b5a2a3926204933c84979/src/modules/core.js#L1639-L1744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants