Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change uriDetails type to URIComponents from uri-js package #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

medfreeman
Copy link

No description provided.

@whitlockjc
Copy link
Owner

This file is generated, I'm not sure how to get @otris/jsdoc-tsd to generate this. Let me do some digging.

@medfreeman
Copy link
Author

I followed your approach to try to use official syntax, then compensate for the shortcomings of @otris/jsdoc-tsd by doing replacements with gulp-replace.
There's also a change in the order of files for the docs-ts-raw gulp task, with index now after typedefs, which also reverses the output.
I think it's the smallest change for it to work.
Is it acceptable to you?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants