-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abort reason to abort fetch #1343
Merged
Merged
Changes from 24 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
a18ee76
add abort reason to abort fetch
nidhijaju 6e0fe40
add name to acknowledgments
nidhijaju 4a06427
remove if condition
nidhijaju eb499b4
use aborted predicate
nidhijaju c0833a5
fix
nidhijaju 55d734e
Merge branch 'whatwg:main' into update-with-abortreason
nidhijaju 4df5ef6
use aborted predicate
nidhijaju 75d4bad
make changes
nidhijaju b6ddcaa
fix syntax
nidhijaju ba73b86
address comments
nidhijaju ddd1628
Apply suggestions from code review
nidhijaju 62edcfe
Merge branch 'whatwg:main' into update-with-abortreason
nidhijaju 14dac0d
incorporate review comments
nidhijaju 8194bf6
update abort controller
nidhijaju f660a6e
update fetch()
nidhijaju 2255611
move serialization to abort fetch
nidhijaju f44930c
pass reason to cancelAlgorithm
nidhijaju 122bae5
address comments
nidhijaju cc54cd6
rename abort fetch
nidhijaju 647f4f5
Apply suggestions from code review
nidhijaju e5b0236
Merge branch 'whatwg:main' into update-with-abortreason
nidhijaju 1b86ddc
resolve conflict
nidhijaju b6a779d
fix
nidhijaju 6a0f4aa
wrap fetch with <code>
nidhijaju 63ad081
deserialize abort reason
nidhijaju f86437e
use controller's reason
nidhijaju 38ea956
fix indentation
nidhijaju 662fe10
fix deserialization & make serialized reason default undefined
nidhijaju 70ade67
fix indentation
nidhijaju a29fd77
wrap abort fetch calls in <code>
nidhijaju 01a87c0
Go back to null instead of undefined, address logic sharing comment, …
annevk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: might want to add a source comment here about this being a Record.