Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues on Magento 2.3.2 #4

Open
RaFr opened this issue Aug 20, 2019 · 2 comments
Open

issues on Magento 2.3.2 #4

RaFr opened this issue Aug 20, 2019 · 2 comments

Comments

@RaFr
Copy link

RaFr commented Aug 20, 2019

Hello,

i tested the extension on a Magento 2.3.2 installation and i detected the following issues:
-on the customer page, if the w3w address is copied, the 'save address' button stays enabled. but if the address is typed, the button is disabled when start typing and stays disabled even after selecting the address suggested by the extension.
-in the suggested address, the country is correct but the city isn't. this could be confusing to the customer.
-the customer address can't be edited from admin backend. it throws server errors and modifications are not applied. when the extension is removed, the address can be edited again without errors.
i couldn't test it on the checkout page as i have a 3rd party OSC extension, and i didn't implement w3w extension yet because of the above errors.

kind regards

@andycurriew3w
Copy link
Contributor

Hello,

Could I confirm that you installed the extension from composer/packagist using composer require what3words/module-what3words? For the first issue it sounds like one of the module's dependencies didnt install.

With the nearest place issue, we use a nearest places dataset that doesn't contain every place in the world as it needs to be small enough to work offline. The place is therefore indicative and something we are working on to optimise our dataset. It will be correct in the majority of places but sometimes may show an unexpected location.

The final issue with the admin backend we are currently investigating and hope to have a fix next week.

Regards

Andy

@RaFr
Copy link
Author

RaFr commented Aug 23, 2019

Hello,

I installed the extension manually trough ftp. I didn't install it using composer.

Is there an option in the code to not show the nearest place when the place is very small. Not showing a place is better than showing a wrong one as the customer would think that he picked the wrong address. In the test i've done, it showed the region which is a good solution for small places, but it showed a wrong region that is not bigger than the correct region. IMHO, in such cases, showing only the country may be enough if the correct address is not available, specially that the extension will be mostly used for small and not well identified addresses.

Thanks and regards,
RA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@RaFr @andycurriew3w and others