Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Latest Frog not compiling Next.js -- missing title #440

Closed
thebreadcat opened this issue Jul 25, 2024 · 3 comments
Closed

Issue with Latest Frog not compiling Next.js -- missing title #440

thebreadcat opened this issue Jul 25, 2024 · 3 comments
Labels
Good First Issue Misc: Good First Issue

Comments

@thebreadcat
Copy link

Describe the bug

run the frog command from the docs npm init frog -- -t next and it creates a project, cd into it, npm install, then push to vercel immediately. It fails to deploy. running "yarn build" or "npm run build" locally then produces this error:

Type error: Argument of type '{ assetsPath: string; basePath: string; }' is not assignable to parameter of type 'FrogConstructorParameters<Env, "/" | "/api", unknown>'.
  Property 'title' is missing in type '{ assetsPath: string; basePath: string; }' but required in type 'Required<Pick<FrameResponse, "title">>'.

   5 | import { handle } from 'frog/next'
   6 |
>  7 | const app = new Frog({
     |                      ^
   8 |   assetsPath: '/',
   9 |   basePath: '/api',
  10 |   // Supply a Hub to enable frame verification.```

Adding a title in to the App declaration fixes the issue.  May need to update the install script.


### Link to Minimal Reproducible Example

https://frog.fm

### Steps To Reproduce

Defined above

### Frog Version

0.15.2

### TypeScript Version

5.5.3

### Check existing issues

- [X] I checked there isn't [already an issue](https://github.com/wevm/frog/issues) for the bug I encountered.

### Anything else?

_No response_
@tmm tmm added the Good First Issue Misc: Good First Issue label Jul 25, 2024
@tmm
Copy link
Member

tmm commented Jul 25, 2024

Easy first issue for someone. Just need to add title: 'Frog Frame' to all the templates.

@thebreadcat
Copy link
Author

it looks like they were all added 4 days ago but the scripts when you run them to create frog aren't pulling in titles (I did a fresh run for next.js today)

@dalechyn
Copy link
Collaborator

Can't reproduce. Are you sure you have frog up to date? It can be that you have it installed globally and it's outdated.

If still reproducible, please reopen.

Export-1722029974244.mp4

Screenshot 2024-07-27 at 00 41 01

@dalechyn dalechyn closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Misc: Good First Issue
Projects
None yet
Development

No branches or pull requests

3 participants