Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrogUI: Malformed apostrophes in State #323

Closed
1 task done
gigabit-eth opened this issue May 16, 2024 · 1 comment
Closed
1 task done

FrogUI: Malformed apostrophes in State #323

gigabit-eth opened this issue May 16, 2024 · 1 comment
Labels
Good First Issue Misc: Good First Issue Needs Reproduction Misc: Needs Reproduction

Comments

@gigabit-eth
Copy link

gigabit-eth commented May 16, 2024

Describe the bug

When a user clicks a button to receive a random question, if the question contains an apostrophe, the text is malformed on subsequent renders after navigating back and forth. This issue seems to stem from the currentState not properly handling apostrophes.

Screenshot 1: Initial Render
exhibit-1

Screenshot 2: Subsequent Render
exhibit-1b

Link to Minimal Reproducible Example

No response

Steps To Reproduce

Initial State:

  • User clicks a button to receive a random question.
  • The question contains an apostrophe and appears correctly in the UI from the API GET response.

Trigger the Issue:

  • User navigates back to the previous screen.
  • User clicks the same button again to receive the same random question.

Observe:

  • The question text is now malformed in the UI (e.g., What & # 3 9 ; s instead of What's).

Expected Behavior

The question text should consistently appear correctly, with apostrophes properly rendered as intended (e.g., What's).

Actual Behavior

Upon the second render after navigating back and forth, the apostrophe in the question text is replaced with its HTML entity (e.g., What & # 3 9 ; s).

Potential Cause

It seems that the 'currentState' is not correctly handling apostrophes, leading to the text being malformed upon subsequent renders.

Frog Version

0.11.2

TypeScript Version

5

Check existing issues

Anything else?

No response

@tmm tmm added Good First Issue Misc: Good First Issue Needs Reproduction Misc: Needs Reproduction and removed Needs Reproduction Misc: Needs Reproduction labels May 17, 2024
Copy link
Contributor

Hello @gigabit-eth.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config & environment, and trying to reproduce your issue. See Why reproductions are required.

Please reopen this issue when a reproduction is added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Misc: Good First Issue Needs Reproduction Misc: Needs Reproduction
Projects
None yet
Development

No branches or pull requests

2 participants