Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out of memory when frog dev recursively navigates directories in user home #228

Closed
1 task done
christopherwxyz opened this issue Apr 4, 2024 · 2 comments · Fixed by #257
Closed
1 task done
Labels
P: Low Priority: Low T: Bug Type: Bug

Comments

@christopherwxyz
Copy link
Contributor

Describe the bug

when running frog dev outside the project directory, the terminal will cause permissions to flag as devtools works its way down the disk. eventually this will fail as it exhausts memory.

image

image

Link to Minimal Reproducible Example

No response

Steps To Reproduce

run frog dev in a user home directory

Frog Version

0.7.6+

TypeScript Version

No response

Check existing issues

Anything else?

No response

@dalechyn
Copy link
Collaborator

dalechyn commented Apr 5, 2024

perhaps devtools could detect if the current folder has a package.json to start in watch mode, and disable watch mode totally if not

@tmm
Copy link
Member

tmm commented Apr 5, 2024

@dalechyn if injectClientScript is false, then devtools are running in standalone mode so watch can be disabled. PR welcome!

https://github.com/wevm/frog/blob/main/src/cli/commands/dev.ts#L28

@dalechyn dalechyn added P: Low Priority: Low T: Bug Type: Bug labels Apr 20, 2024
@tmm tmm closed this as completed in #257 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: Low Priority: Low T: Bug Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants