From 3be19381abc70105f99f6f100adff88ffc92d16f Mon Sep 17 00:00:00 2001
From: "moxey.eth" <jakemoxey@gmail.com>
Date: Tue, 13 Feb 2024 07:48:08 +1100
Subject: [PATCH] feat: `basePath`; tighten `Farc` return type API

---
 examples/_dev/src/index.tsx |  6 +--
 examples/_dev/src/todos.tsx |  4 --
 src/farc.tsx                | 89 +++++++++++++++++++++++--------------
 src/utils/toBaseUrl.ts      |  3 --
 4 files changed, 56 insertions(+), 46 deletions(-)
 delete mode 100644 src/utils/toBaseUrl.ts

diff --git a/examples/_dev/src/index.tsx b/examples/_dev/src/index.tsx
index 8111bb35..3300492e 100644
--- a/examples/_dev/src/index.tsx
+++ b/examples/_dev/src/index.tsx
@@ -1,11 +1,7 @@
-/** @jsx jsx */
-/** @jsxImportSource hono/jsx */
-/** @jsxFrag */
-
 import { Button, Farc, TextInput } from 'farc'
 import { app as todoApp } from './todos'
 
-const app = new Farc()
+const app = new Farc({ basePath: '/api' })
 
 app.frame('/', (context) => {
   const { buttonValue, inputText, status } = context
diff --git a/examples/_dev/src/todos.tsx b/examples/_dev/src/todos.tsx
index dd152355..5fa5af46 100644
--- a/examples/_dev/src/todos.tsx
+++ b/examples/_dev/src/todos.tsx
@@ -1,7 +1,3 @@
-/** @jsx jsx */
-/** @jsxImportSource hono/jsx */
-/** @jsxFrag */
-
 import { Button, Farc, TextInput } from 'farc'
 
 type State = {
diff --git a/src/farc.tsx b/src/farc.tsx
index 68c69b05..38d4834f 100644
--- a/src/farc.tsx
+++ b/src/farc.tsx
@@ -27,12 +27,14 @@ import { parseIntents } from './utils/parseIntents.js'
 import { parsePath } from './utils/parsePath.js'
 import { requestToContext } from './utils/requestToContext.js'
 import { serializeJson } from './utils/serializeJson.js'
-import { toBaseUrl } from './utils/toBaseUrl.js'
 
 export type FarcConstructorParameters<
   state = undefined,
   env extends Env = Env,
-> = HonoOptions<env> & {
+  basePath extends string = '/',
+> = {
+  basePath?: basePath | string | undefined
+  honoOptions?: HonoOptions<env> | undefined
   initialState?: state | undefined
 }
 
@@ -48,14 +50,21 @@ export class Farc<
   env extends Env = Env,
   schema extends Schema = {},
   basePath extends string = '/',
-> extends Hono<env, schema, basePath> {
+> {
   #initialState: state = undefined as state
 
+  hono: Hono<env, schema, basePath>
+  fetch: Hono<env, schema, basePath>['fetch']
+
   constructor({
+    basePath,
+    honoOptions,
     initialState,
-    ...options
-  }: FarcConstructorParameters<state, env> = {}) {
-    super(options)
+  }: FarcConstructorParameters<state, env, basePath> = {}) {
+    this.hono = new Hono<env, schema, basePath>(honoOptions)
+    if (basePath) this.hono = this.hono.basePath(basePath)
+    this.fetch = this.hono.fetch.bind(this.hono)
+
     if (initialState) this.#initialState = initialState
   }
 
@@ -67,8 +76,12 @@ export class Farc<
     ) => FrameHandlerReturnType | Promise<FrameHandlerReturnType>,
   ) {
     // Frame Route (implements GET & POST).
-    this.use(path, async (c) => {
+    this.hono.use(parsePath(path), async (c) => {
       const query = c.req.query()
+
+      const url = new URL(c.req.url)
+      const baseUrl = `${url.origin}${url.pathname}`
+
       const previousContext = query.previousContext
         ? deserializeJson<PreviousFrameContext<path, state>>(
             query.previousContext,
@@ -127,9 +140,7 @@ export class Farc<
             <meta
               property="fc:frame:post_url"
               content={`${
-                action
-                  ? toBaseUrl(c.req.url) + parsePath(action || '')
-                  : context.url
+                action ? baseUrl + parsePath(action || '') : context.url
               }?${postSearch}`}
             />
             {parsedIntents}
@@ -160,7 +171,7 @@ export class Farc<
     })
 
     // OG Image Route
-    this.get(`${parsePath(path)}/image`, async (c) => {
+    this.hono.get(`${parsePath(path)}/image`, async (c) => {
       const query = c.req.query()
       const previousContext = query.previousContext
         ? deserializeJson<PreviousFrameContext<path, state>>(
@@ -178,27 +189,28 @@ export class Farc<
     })
 
     // Frame Dev Routes
-    this.use(`${parsePath(path)}/dev`, (c, next) =>
-      jsxRenderer((props) => {
-        const { children } = props
-        const path = new URL(c.req.url).pathname.replace('/dev', '')
-        return (
-          <html lang="en">
-            <head>
-              <title>𝑭𝒂𝒓𝒄 {path || '/'}</title>
-              <Style />
-              {/* TODO: Switch to bundling */}
-              <script
-                src="https://unpkg.com/htmx.org@1.9.10"
-                integrity="sha384-D1Kt99CQMDuVetoL1lrYwg5t+9QdHe7NLX/SoJYkXDFfX37iInKRy5xLSi8nO7UC"
-                crossorigin="anonymous"
-              />
-            </head>
-            <body>{children}</body>
-          </html>
-        )
-      })(c, next),
-    )
+    this.hono
+      .use(`${parsePath(path)}/dev`, (c, next) =>
+        jsxRenderer((props) => {
+          const { children } = props
+          const path = new URL(c.req.url).pathname.replace('/dev', '')
+          return (
+            <html lang="en">
+              <head>
+                <title>𝑭𝒂𝒓𝒄 {path || '/'}</title>
+                <Style />
+                {/* TODO: Switch to bundling */}
+                <script
+                  src="https://unpkg.com/htmx.org@1.9.10"
+                  integrity="sha384-D1Kt99CQMDuVetoL1lrYwg5t+9QdHe7NLX/SoJYkXDFfX37iInKRy5xLSi8nO7UC"
+                  crossorigin="anonymous"
+                />
+              </head>
+              <body>{children}</body>
+            </html>
+          )
+        })(c, next),
+      )
       .get(async (c) => {
         const baseUrl = c.req.url.replace('/dev', '')
         const response = await fetch(baseUrl)
@@ -206,7 +218,7 @@ export class Farc<
 
         const frame = htmlToFrame(text)
         const state = htmlToState(text)
-        const routes = getRoutes(baseUrl, inspectRoutes(this))
+        const routes = getRoutes(baseUrl, inspectRoutes(this.hono))
 
         return c.render(<Dev {...{ baseUrl, frame, routes, state }} />)
       })
@@ -326,11 +338,20 @@ export class Farc<
         // TODO: handle redirects
         const frame = htmlToFrame(text)
         const state = htmlToState(text)
-        const routes = getRoutes(baseUrl, inspectRoutes(this))
+        const routes = getRoutes(baseUrl, inspectRoutes(this.hono))
 
         return c.render(
           <Preview {...{ baseUrl, error, frame, routes, state }} />,
         )
       })
   }
+
+  route<
+    subPath extends string,
+    subEnv extends Env,
+    subSchema extends Schema,
+    subBasePath extends string,
+  >(path: subPath, farc: Farc<any, subEnv, subSchema, subBasePath>) {
+    return this.hono.route(path, farc.hono)
+  }
 }
diff --git a/src/utils/toBaseUrl.ts b/src/utils/toBaseUrl.ts
deleted file mode 100644
index 162441e7..00000000
--- a/src/utils/toBaseUrl.ts
+++ /dev/null
@@ -1,3 +0,0 @@
-export function toBaseUrl(url: string) {
-  return new URL(url).origin
-}