Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset_stack() method and self.betting appear to be redundant in player.py? #16

Open
BigBadBurrow opened this issue Feb 11, 2019 · 2 comments

Comments

@BigBadBurrow
Copy link

BigBadBurrow commented Feb 11, 2019

reset_stack() method doesn't appear to be referenced

self.betting defined in player.py appear to be redundant (it's only ever set to False), but care needs to be taken if removed as it's used in player_features[], so removing it will change the indexes of the list, which may be used elsewhere.

@VinQbator
Copy link

I'm using reset_stack() to reset stacks after every episode of training. As you can see from the name, it does not have underscore before it - thus it is public.

Can't comment on self.betting yet

@BigBadBurrow
Copy link
Author

Okay, just beware you've hard-coded it to 2000 and it's possible to initialise players which varying stack sizes via env.add_player()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants