Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink warning about 'no validation file' when loading or creating a model with default deepforecast_config.yml #664

Closed
ethanwhite opened this issue May 7, 2024 · 2 comments · Fixed by #671
Assignees

Comments

@ethanwhite
Copy link
Member

The most basic thing we do triggers a warning that is confusing to users:

>>> from deepforest import main
>>> model = main.deepforest()
Reading config file: /home/ethan/miniconda3/envs/DeepForest/lib/python3.11/site-packages/deepforest/data/deepforest_config.yml
No validation file provided. Turning off validation loop
...

We've gotten a number of questions (#557, #655, #653), about this warning and it is particularly confusing if users add a validation file in the code and then create a trainer, since they are seeing an error that implies that this didn't work, but it's actually occurring before the validation file is defined and the trainer created.

@ethanwhite
Copy link
Member Author

@bw4sz & @henrykironde what do you think about this?

@bw4sz
Copy link
Collaborator

bw4sz commented May 7, 2024

Yes, in general I think it actually could be silent without a problem.

ethanwhite added a commit to ethanwhite/DeepForest that referenced this issue May 11, 2024
This warning is triggered anytime a model is created and causes confusion for zero-shot users weecology#664.

Closes weecology#664
bw4sz pushed a commit that referenced this issue Jun 13, 2024
This warning is triggered anytime a model is created and causes confusion for zero-shot users #664.

Closes #664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants