Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scheduled time does not take effect when the task status is error #8

Open
tsun424 opened this issue Mar 9, 2017 · 3 comments
Open

Comments

@tsun424
Copy link

tsun424 commented Mar 9, 2017

If the status of a task is error, this task runs every time when the OS cron job runs even it's not the scheduled time.
For example, we set the task scheduled time to */5 8-20 * * *, if it's error, it will be run even after 8pm until the task runs successfully.
Below snapshot shows the scenario:
screen shot 2017-03-10 at 12 05 46 pm

@brucealdridge
Copy link
Contributor

@tsun424 this is expected behaviour AFAIK, so if for eg an API is down it will retry until it succeeds. However there should probably be an option here, eg $automatic_retry_on_fail = true

@tsun424
Copy link
Author

tsun424 commented Jul 4, 2017

The mechanism of retry is OK, but I think this retry should happen only during scheduled time. From my point of view, scheduled time should have higher priority in this scenario. If a new option will be added, how about $automatic_retry_out_schedule?

@brucealdridge
Copy link
Contributor

it really depends on the job. because you say it should only happen during the scheduled time.
That works find if you have * 10-16 * * * but not if you have 0 0 * * *
Might make more sense to have a $retry_schedule option with the same format, default being * * * * *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants