Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name (for Java libs) #54

Open
hendrikebbers opened this issue May 24, 2023 · 3 comments
Open

Add Automatic-Module-Name (for Java libs) #54

hendrikebbers opened this issue May 24, 2023 · 3 comments

Comments

@hendrikebbers
Copy link

The java modules does have a module-info.java or provide an "Automatic-Module-Name" (in MANIFEST.MF). At least the info to the manifest should be added to provide compatibility in projects that use the Java module system. More details: http://branchandbound.net/blog/java/2017/12/automatic-module-name/
For this project as a first simple step a MVN plugin would be good enough to add "Automatic-Module-Name" to all modules. If you are interested I could create a PR the next days :)

@ashleyfrieze
Copy link
Member

@hendrikebbers - please go for it. One minor warning is that this project compiles in JDK8. Not sure if the maven stuff will do what want in that version, but feel free to give it a shot.

@hendrikebbers
Copy link
Author

@ashleyfrieze the simplest solution is to add metadata to the MANIFEST. That is independent of the Java version. I will start with that step.

@ashleyfrieze
Copy link
Member

@hendrikebbers - sounds great. Give me a shout if you need help.

Long-term I will stop supporting JDK8, or at least branch that off and focus more on later Java versions. For now, if you're able to get things building using the mvnw and a JDK 8 environment, that'll be great.

Note: this software will not build on later Java versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants