Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: optimize the ecma version check. #532

Open
easy1090 opened this issue Sep 24, 2024 · 3 comments
Open

[Feature]: optimize the ecma version check. #532

easy1090 opened this issue Sep 24, 2024 · 3 comments
Assignees

Comments

@easy1090
Copy link
Collaborator

easy1090 commented Sep 24, 2024

What problem does this feature solve?

  1. Support users in configuring the version number for ECMAScript testing.
  2. Support for ecma version 8.

What does the proposed API look like?

linter: {
        rules: {
          'ecma-version-check': [
            'Error',
            {
              checkVersion: 7, // enum, 6 | 7 | 8
              exclude: [] // exclude some files. 
            },
          ],
        },
    }
@nyqykk
Copy link
Member

nyqykk commented Nov 20, 2024

checkVersion maybe better changed to ES2015 and so on

@chenjiahan
Copy link
Member

@nyqykk How about align options with rsbuild-plugin-check-syntax:

https://github.com/rspack-contrib/rsbuild-plugin-check-syntax?tab=readme-ov-file#options

@nyqykk
Copy link
Member

nyqykk commented Nov 20, 2024

Good suggestion

@nyqykk How about align options with rsbuild-plugin-check-syntax:

https://github.com/rspack-contrib/rsbuild-plugin-check-syntax?tab=readme-ov-file#options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants