Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Gallery stuck with loading spinner when used with ChangeDetectionStrategy.OnPush #59

Open
cat-mandres opened this issue May 12, 2020 · 1 comment
Open

Image Gallery stuck with loading spinner when used with ChangeDetectionStrategy.OnPush #59

cat-mandres opened this issue May 12, 2020 · 1 comment

Comments

@cat-mandres
Copy link

Due to the use of Promises (I think) for loading the images, the gallery is stuck at the loading spinner until another change detection is done if the application is using the ChangeDetectionStrategy.OnPush.
@cat-mandres cat-mandres mentioned this issue May 12, 2020
Merged
@cat-mandres
Copy link
Author

I created a pull request to fix this issue already:

#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cat-mandres