Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation not up to date #28

Open
Serrulien opened this issue Jul 24, 2018 · 2 comments
Open

documentation not up to date #28

Serrulien opened this issue Jul 24, 2018 · 2 comments

Comments

@Serrulien
Copy link

Serrulien commented Jul 24, 2018

prev and next don't take arguments.

in component (as you can see no args) :
https://github.com/thatisuday/ngx-image-gallery/blob/c8403fca3084a9127d5e634c0c17131744c5787e/src/components/ngx-image-gallery/ngx-image-gallery.component.ts#L315-L327

But in the documentation :
https://github.com/thatisuday/ngx-image-gallery/blob/c8403fca3084a9127d5e634c0c17131744c5787e/README.md#L131-L139

@jaasmaz
Copy link

jaasmaz commented Aug 2, 2018

I'm having the same problem did you fix it?

@Serrulien
Copy link
Author

Serrulien commented Aug 2, 2018

@jaasmaz I don't understand your problem. The gallery remains fully functional even if the documentation contains some errors.
You should get a type error when giving an argument to next or prev methods as the .d.ts file is up to date. Thus just don't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants