Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClojureScript support #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

clyfe
Copy link

@clyfe clyfe commented Dec 6, 2020

Issue #15

@weavejester
Copy link
Owner

Can you remove the Add deps.edn commit? A PR should contain commits relating to a single change.

@kidpollo
Copy link

Merging this would be awesome!

@twashing
Copy link

Merging this would be awesome!

I also have a use case that needs Clojurescript support. Lo and behold this PR is already here. Thanks for the work @clyfe!

@ckirkendall
Copy link

ckirkendall commented Mar 8, 2021

@weavejester - is there anything in this PR that is holding up bringing this into the main line.

@weavejester
Copy link
Owner

@weavejester - is there anything in this PR that is holding up bringing this into the main line.

Mostly me finding time to test this, since it currently can't be done automatically.

Speaking of which, there doesn't appear to be any development setup for this change. I've confirmed the Clojure version works, but I'd appreciate some :dev profile setup for ClojureScript, so I can test that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants