Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTT2 - Logging - Improve log file naming and location #5204

Open
rauldpm opened this issue Apr 11, 2024 · 1 comment
Open

DTT2 - Logging - Improve log file naming and location #5204

rauldpm opened this issue Apr 11, 2024 · 1 comment

Comments

@rauldpm
Copy link
Member

rauldpm commented Apr 11, 2024

Description

DTT1 is storing logs in a hardcoded file located in /tmp/workflow.log

╰─➤  grep -R "workflow\.log"
modules/generic/logger/config.yaml:    filename: /tmp/workflow.log
modules/workflow_engine/logger/config.yaml:    filename: /tmp/workflow.log
modules/build/lib/workflow_engine/logger/config.yaml:    filename: /tmp/workflow.log
modules/testing/tests/helpers/logger/config.yaml:    filename: /tmp/workflow.log

Every DTT execution appends the log to this file, we should improve the logging feature with specific log files instead of adding all the logs to a single file

Also, we should modify the log file path as the temporal directory is not the correct path for this type of file.

That is, the log should be stored in a file identified by name-year-month-day-hour-minutes-secons.log

@mhamra
Copy link
Contributor

mhamra commented Apr 16, 2024

UPDATE

The deployability/modules/generic/logger/config.yaml file defines the log file's "hardcoded" path.

Implementing the proposed default log file name name-year-month-day-hour-minutes-secons.log requires that the main files of the allocation, provision, and testing modules can receive the default log file location as a parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants