Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goals / platforms #66

Closed
wants to merge 8 commits into from
Closed

goals / platforms #66

wants to merge 8 commits into from

Conversation

GaryPWhite
Copy link
Collaborator

@GaryPWhite GaryPWhite commented Nov 22, 2022

Description

resolves #9

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@GaryPWhite GaryPWhite requested a review from lelia November 22, 2022 16:16
@GaryPWhite
Copy link
Collaborator Author

resolves #9

Copy link
Collaborator

@lelia lelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly phrasing stuff, overall platform/goals content looks great

src/docs/goals/platforms.md Outdated Show resolved Hide resolved
src/docs/goals/platforms.md Outdated Show resolved Hide resolved
src/docs/goals/platforms.md Outdated Show resolved Hide resolved
src/docs/goals/platforms.md Outdated Show resolved Hide resolved
src/docs/goals/platforms.md Outdated Show resolved Hide resolved
src/docs/goals/platforms.md Outdated Show resolved Hide resolved
src/docs/goals/platforms.md Outdated Show resolved Hide resolved
src/docs/goals/platforms.md Outdated Show resolved Hide resolved
@natalisucks
Copy link
Collaborator

Lelia's review was comprehensive; I added a couple of addition comments. Happy to LGTM this once proposed changes have been reviewed/applied.

@lelia lelia mentioned this pull request Dec 16, 2022
6 tasks
@GaryPWhite GaryPWhite closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/src/docs/goals/platforms.md
3 participants