Integration tests infrastructure refactoring. Separation of creation … #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of nodes containers. Functional options implemented for itests configuration.
alexeykiselev
added
enhancement
Context cancellation moved to the end of Finish function.
nickeskov
force-pushed
the
itest-infra-refactoring
branch
from
d4ce937 to
47e161c
Compare
alexeykiselev
removed
wip
nickeskov
requested changes
Sep 12, 2024
nickeskov
reviewed
Sep 13, 2024
nickeskov
previously approved these changes
Sep 13, 2024
…tain height then the sponsorship starts working.
… with explanation of the constant added.
…waves into itest-infra-refactoring
nickeskov
previously approved these changes
Sep 13, 2024
Features activation height type changed from int32 to uint64. Itests will panic on preactivated features with negative height in Scala node.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nickeskov
requested changes
Sep 27, 2024
Use errgroup for running goroutines, use and pass contexts.
Add global timeout to WaitForHeight function. Remove unused function.
nickeskov
requested changes
Sep 27, 2024
|
LGTM, will approve after #1505 will be merged to master. |
nickeskov
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of nodes containers.
Functional options implemented for itests configuration.