You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of #99, cranelift_wasm::FuncEnvironment::declare_vmruntime_limits_ptr is always executed unconditionally in before_translate_function. This is to ensure that the ir::Variable named vmruntime_limits_ptr can always be used in translate_resume. It would be better to check if there is a resume instruction in the function under consideration, and make the execution of declare_vmruntime_limits_ptr dependent on that.
However, the current workaround should have no runtime overhead, as it simply adds a CLIF load that is potentially unused and therefore eliminated if we don't actually translate a resume.
The text was updated successfully, but these errors were encountered:
As of #99,
cranelift_wasm::FuncEnvironment::declare_vmruntime_limits_ptr
is always executed unconditionally inbefore_translate_function
. This is to ensure that their::Variable
namedvmruntime_limits_ptr
can always be used intranslate_resume
. It would be better to check if there is aresume
instruction in the function under consideration, and make the execution ofdeclare_vmruntime_limits_ptr
dependent on that.However, the current workaround should have no runtime overhead, as it simply adds a CLIF load that is potentially unused and therefore eliminated if we don't actually translate a
resume
.The text was updated successfully, but these errors were encountered: