Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.monitor() does not return true #47

Open
hipotenusa opened this issue Nov 4, 2017 · 5 comments · May be fixed by #66
Open

client.monitor() does not return true #47

hipotenusa opened this issue Nov 4, 2017 · 5 comments · May be fixed by #66

Comments

@hipotenusa
Copy link

Hi washo4evr,

I think that "return 1;" is missing on line 136 of "SocketIOClient.cpp" file.

Thanks!

@hipotenusa
Copy link
Author

Hi guys,
Any comment on this?? If this is not an issue I dont know what I am doing wrong to never get true from client.monitor()
Thanks!

@washo4evr
Copy link
Owner

Hi,

sorry for the delay.
I'm working on what would be version 2 of this library
the code can be improved quite a bit

as for the client.monitor, it is just used for the data

@maartenlambrecht
Copy link

Hi Washo4evr,
Thanks a lot for this very useful library!

In the example code it looks like client.monitor needs to be true to pass to next code:

if (client.monitor()) { lastreply = millis(); Serial.println(RID); if (RID == "atime" && Rname == "time") { Serial.print("Il est "); Serial.println(Rcontent); } }

I'm putting the code out of the if -statement to get it working.

@guilhermelirio
Copy link

guilhermelirio commented Oct 1, 2018

Hi Washo4evr,
Thanks a lot for this very useful library!

In the example code it looks like client.monitor needs to be true to pass to next code:

if (client.monitor()) { lastreply = millis(); Serial.println(RID); if (RID == "atime" && Rname == "time") { Serial.print("Il est "); Serial.println(Rcontent); } }

I'm putting the code out of the if -statement to get it working.

Same problem with me. =/

Any solution?

@WingLim WingLim linked a pull request Jun 19, 2019 that will close this issue
@jbteja
Copy link
Contributor

jbteja commented May 16, 2020

@washo4evr ,

Think, this issue can be close. It's same as #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants