Least authority remediation #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
This reverts commit ecdc09d.
merolish
reviewed
Nov 12, 2024
Comment on lines
+190
to
+192
| let mut retval = [F::zero(); N]; | ||
| retval[0] = F::default(); | ||
| Self::new(&retval) |
Comment on lines
+609
to
+610
| let a = Fp12::rand(&mut OsRng); | ||
| let b = Fp12::rand(&mut OsRng); |
There was a problem hiding this comment.
They'd prefer nondeterministic unit tests?
There was a problem hiding this comment.
Yes, they want fuzz/property tests. This is correct IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request addresses a few key concerns highlighted by the audit. These involve test coverage of edge cases in the higher level field extensions, an improved method for generating random elements in$\mathbb{G}_1$ and $\mathbb{G}_2$ , as well as clarifying miscallaneous typos, incorrect references in the comments, etc. Additionally, suggested improvements have been included. See the official response to the audit for more details.