Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow on Large Pull Requests #248

Open
jsoa-gp opened this issue Jul 22, 2023 · 1 comment
Open

Slow on Large Pull Requests #248

jsoa-gp opened this issue Jul 22, 2023 · 1 comment

Comments

@jsoa-gp
Copy link

jsoa-gp commented Jul 22, 2023

Describe the bug
Really slow on large Pull Requests (~1500 files). The process hits "Fetch diff PR ....80%" and hangs for about 20 minutes. There after the code review section loads and easily navigates. Adding a comment, then seems to refresh the entire section, taking another 20 minutes to then again be usable.

To Reproduce
Steps to reproduce the behavior:

  1. Try to review a PR that has many files ~1000 files

Expected behavior
Large PRs to load faster, perhaps asynchronously

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version: Emacs 28.1 (Doom Emacs)

Additional context

I realize that this might be a rare scenario of that many files to diff, and github web is practically un-usable and takes too long to make comments. I had to resort to use vscode with GitHub's PR extension to sanely review the pull request.

@ParetoOptimalDev
Copy link

If you are able I would advise trying out emacs 29 with native compilation and seeing if it improves performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants