Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An update to CloSQL breaks this package #245

Open
tarsius opened this issue Apr 7, 2023 · 0 comments
Open

An update to CloSQL breaks this package #245

tarsius opened this issue Apr 7, 2023 · 0 comments

Comments

@tarsius
Copy link

tarsius commented Apr 7, 2023

I am preparing for a release of EmacSQL, which provides two new SQLite back-ends. These back-ends are safer and faster than the current back-end, and all users should prefer them over the old backend. EmacSQL now also automatically picks the best back-end, depending on the used Emacs version and whether it has been compiled with support for SQLite or modules. Previously packages that used EmacSQL had to either do that themselves or force users to use a certain back-end.

My Forge and Epkg packages use EmacSQL, but they also use the intermediate CloSQL package. While the changes to EmacSQL are backward compatible, those to CloSQL are not. As a consequence, Forge and Epkg could not take advantage of the improvements until I pushed the changes to CLoSQL.

I had to delay doing that because it is not a backward compatible change and because two third-party packages, including Code-Review still need to be adapted. I have informed their maintainers about this over a month ago, but still haven't heard from them.

I have decided to push these changes now anyway, because I do not want to withhold these improvements from most users any longer. Unfortunately this breaks Code-Review until it is adjusted. I wish we could have handled this more gracefully.

@tarsius tarsius changed the title * An update to CloSQL breaks this package An update to CloSQL breaks this package Apr 7, 2023
iyefrat added a commit to iyefrat/doom-emacs that referenced this issue Apr 8, 2023
magit/closql@c3b34a6ec438 -> magit/closql@0a7226331ff1

---

closql c3b34a6 breaks code-review wandersoncferreira/code-review#245,
and the current forge commit (but forge does have an upstream fix),
pinned as a temporary measure to prevent user breakages
iyefrat added a commit to iyefrat/doom-emacs that referenced this issue Apr 8, 2023
magit/closql@c3b34a6ec438 -> magit/closql@0a7226331ff1

---

closql c3b34a6 breaks code-review wandersoncferreira/code-review#245,
and the current forge commit (but forge does have an upstream fix),
pinned as a temporary measure to prevent user breakages
iyefrat added a commit to iyefrat/doom-emacs that referenced this issue Apr 11, 2023
magit/closql@c3b34a6ec438 -> magit/closql@0a7226331ff1

---

closql c3b34a6ec438 breaks code-review
wandersoncferreira/code-review#245, and the current forge commit (but
forge does have an upstream fix), pinned as a temporary measure to
prevent user breakages

Ref: wandersoncferreira/code-review#245
Ref: magit/closql#8
Fix: doomemacs#7197
iyefrat added a commit to iyefrat/doom-emacs that referenced this issue Apr 11, 2023
magit/closql@c3b34a6ec438 -> magit/closql@0a7226331ff1

---

closql c3b34a6ec438 breaks code-review
wandersoncferreira/code-review#245, and the current forge commit (but
forge does have an upstream fix), pinned as a temporary measure to
prevent user breakages

Ref: wandersoncferreira/code-review#245
Ref: magit/closql#8
Fix: doomemacs#7191
hlissner pushed a commit to doomemacs/doomemacs that referenced this issue Apr 12, 2023
magit/closql@c3b34a6ec438 -> magit/closql@0a7226331ff1

---

closql c3b34a6ec438 breaks code-review
wandersoncferreira/code-review#245, and the current forge commit (but
forge does have an upstream fix), pinned as a temporary measure to
prevent user breakages

Ref: wandersoncferreira/code-review#245
Ref: magit/closql#8
Fix: #7191
hlissner added a commit to doomemacs/doomemacs that referenced this issue Aug 18, 2023
alphapapa/magit-todos@c6f3fd03aa5b -> alphapapa/magit-todos@cadf29d1cc41
magit/magit@97a95f70079b -> magit/magit@48818355728c

I am still holding back on bumping forge, code-review, and closql
because of wandersoncferreira/code-review#245. I've created a closql
fork to address this (at doomelpa/code-review), but am still testing it.

Fix: #7277
Ref: wandersoncferreira/code-review#245
Zetagon pushed a commit to Zetagon/doom-emacs that referenced this issue Oct 17, 2023
alphapapa/magit-todos@c6f3fd03aa5b -> alphapapa/magit-todos@cadf29d1cc41
magit/magit@97a95f70079b -> magit/magit@48818355728c

I am still holding back on bumping forge, code-review, and closql
because of wandersoncferreira/code-review#245. I've created a closql
fork to address this (at doomelpa/code-review), but am still testing it.

Fix: doomemacs#7277
Ref: wandersoncferreira/code-review#245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant