You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
QUESTION: where should point be to make single top-level comment? (likely the issue given the error "funcall: Wrong type argument: eieio-object, nil, obj")
#229
Open
abbreviatedman opened this issue
Nov 6, 2022
· 2 comments
(And should documentation for this be added or made more discoverable?)
What I Did
Attempt to create and submit a single top-level comment using
M-x code-review-submit-single-top-level-comment (or s c in the transient menu).
Write a comment.
Submit the comment with C-c C-c(code-review-comment-commit).
What Did I Expect To Have Happen?
A single comment is created in the GitHub PR.
What Happened Instead
An error occurred.funcall: Wrong type argument: eieio-object, nil, obj
No comment was created or submitted.
Theories
Could be a configuration issue on my side, but I believe the following error is from attempting to find the PR at point to add the comment to:
So:
Is this a bug or user config error?
Or (my guess) does the point need to be in a specific place to submit a top-level comment?
Any help is greatly appreciated!
The text was updated successfully, but these errors were encountered:
abbreviatedman
changed the title
QUESTION: where should point be to make single top-level comment?
QUESTION: where should point be to make single top-level comment? (likely the correct path given the error "funcall: Wrong type argument: eieio-object, nil, obj")
Nov 6, 2022
abbreviatedman
changed the title
QUESTION: where should point be to make single top-level comment? (likely the correct path given the error "funcall: Wrong type argument: eieio-object, nil, obj")
QUESTION: where should point be to make single top-level comment? (likely the issue given the error "funcall: Wrong type argument: eieio-object, nil, obj")
Nov 6, 2022
And still seeing it. There haven't been new commits in that time so no
surprise it's not fixed. Is anyone not seeing this behaviour and
hence pointers to a workaround?
(And should documentation for this be added or made more discoverable?)
What I Did
Attempt to create and submit a single top-level comment using
M-x code-review-submit-single-top-level-comment
(ors c
in the transient menu).C-c C-c
(code-review-comment-commit
).What Did I Expect To Have Happen?
A single comment is created in the GitHub PR.
What Happened Instead
An error occurred.
funcall: Wrong type argument: eieio-object, nil, obj
No comment was created or submitted.
Theories
Could be a configuration issue on my side, but I believe the following error is from attempting to find the PR at point to add the comment to:
So:
Any help is greatly appreciated!
The text was updated successfully, but these errors were encountered: