Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUESTION: where should point be to make single top-level comment? (likely the issue given the error "funcall: Wrong type argument: eieio-object, nil, obj") #229

Open
abbreviatedman opened this issue Nov 6, 2022 · 2 comments

Comments

@abbreviatedman
Copy link

(And should documentation for this be added or made more discoverable?)

What I Did

Attempt to create and submit a single top-level comment using

  1. M-x code-review-submit-single-top-level-comment (or s c in the transient menu).
  2. Write a comment.
  3. Submit the comment with C-c C-c(code-review-comment-commit).

What Did I Expect To Have Happen?

A single comment is created in the GitHub PR.

What Happened Instead

An error occurred.funcall: Wrong type argument: eieio-object, nil, obj

No comment was created or submitted.

Theories

Could be a configuration issue on my side, but I believe the following error is from attempting to find the PR at point to add the comment to:

So:

  1. Is this a bug or user config error?
  2. Or (my guess) does the point need to be in a specific place to submit a top-level comment?

Any help is greatly appreciated!

@abbreviatedman abbreviatedman changed the title QUESTION: where should point be to make single top-level comment? QUESTION: where should point be to make single top-level comment? (likely the correct path given the error "funcall: Wrong type argument: eieio-object, nil, obj") Nov 6, 2022
@abbreviatedman abbreviatedman changed the title QUESTION: where should point be to make single top-level comment? (likely the correct path given the error "funcall: Wrong type argument: eieio-object, nil, obj") QUESTION: where should point be to make single top-level comment? (likely the issue given the error "funcall: Wrong type argument: eieio-object, nil, obj") Nov 6, 2022
@Thaodan
Copy link
Contributor

Thaodan commented Nov 30, 2022

I noticed the same issue.

@prayner
Copy link

prayner commented May 11, 2024

And still seeing it. There haven't been new commits in that time so no
surprise it's not fixed. Is anyone not seeing this behaviour and
hence pointers to a workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants