Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't add comment to PR #205

Open
emacsbliss opened this issue Mar 24, 2022 · 6 comments
Open

can't add comment to PR #205

emacsbliss opened this issue Mar 24, 2022 · 6 comments

Comments

@emacsbliss
Copy link

emacsbliss commented Mar 24, 2022

Describe the bug
Got error:

eieio-oset--closql-oset: Wrong type argument: eieio-object, nil, obj

when trying to add single comment to PR

To Reproduce
Steps to reproduce the behavior:

  1. M-x code-review-start, enter PR url
  2. in Code Review buffer, press r then s c
  3. in the Code Review Comment buffer, typed comment, press C-c C-c got error

If I type r followed by c, then will get this error instead:

Errors: "Unprocessable Entity. You need to leave a comment indicating the requested changes."

Expected behavior
A comment should be sent to the PR

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version Emacs 28

Additional context
I'm using enterprise github

@codygman
Copy link

This might be related to a bug I noticed that seemed to be because of either large sized comments with lots of code blocks and/or special characters.

@okybr
Copy link

okybr commented Apr 28, 2022

I experience the same issue - I get the respective error messages in each of the two cases. How can I help trace the cause?

@klochowicz
Copy link

same issue here. Can reproduce on a public repo if needed, happy to join debugging efforts.

@short-king
Copy link

Getting this too. Has anyone had it work in some cases but not others? Example repos where it does and does not work would be helpful.

@z80dev
Copy link

z80dev commented Dec 13, 2023

also hitting the same behavior

@prayner
Copy link

prayner commented May 11, 2024

and still seeing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants