Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): Trace tree: center line to point to the title of the call #3219

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore(ui): Trace tree: center line to point to the title of the call #3219

merged 2 commits into from
Dec 12, 2024

Conversation

m-rgba
Copy link
Contributor

@m-rgba m-rgba commented Dec 12, 2024 •
edited
Loading

Description

  • One-liner that aligns the line with the trace-tree to the center of the call title (vs. the center of the call card).
Before After
CleanShot 2024-12-12 at 11 55 57@2x CleanShot 2024-12-12 at 11 57 55@2x

@m-rgba
Copy link
Contributor Author

m-rgba commented Dec 12, 2024

Updated FeatureBee: https://beta.wandb.ai/?betaVersion=106d5941fd4813094c627460127379ff6f51a27

@m-rgba m-rgba marked this pull request as ready for review December 12, 2024 16:58
@m-rgba m-rgba requested review from a team as code owners December 12, 2024 16:58
@m-rgba m-rgba merged commit a61a50e into master Dec 12, 2024
120 of 121 checks passed
@m-rgba m-rgba deleted the Call-tree-line-centering branch December 12, 2024 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwlee64 jwlee64 jwlee64 approved these changes

@tssweeney tssweeney tssweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-rgba @tssweeney @jwlee64