Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(weave): Remove api_key hardcodes in code examples #3214

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

J2-D2-3PO
Copy link
Contributor

Addresses https://wandb.atlassian.net/browse/DOCS-1120

Removes api_key="..." from examples like https://weave-docs.wandb.ai/tutorial-tracing_2 so that we aren't promoting bad practices. Leaves instances where the api_key is loaded from the environment e.g. os.environ

@J2-D2-3PO J2-D2-3PO self-assigned this Dec 11, 2024
@J2-D2-3PO J2-D2-3PO marked this pull request as ready for review December 11, 2024 23:52
@J2-D2-3PO J2-D2-3PO requested a review from a team as a code owner December 11, 2024 23:52
@circle-job-mirror
Copy link

circle-job-mirror bot commented Dec 12, 2024

@J2-D2-3PO J2-D2-3PO merged commit 9bda890 into master Dec 12, 2024
120 checks passed
@J2-D2-3PO J2-D2-3PO deleted the DOCS-1120 branch December 12, 2024 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants