fix(weave): fixed a bug where Evaluation.predict_and_score tried accessing __name__ #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…__ on a Callable instance
|
This PR requires manual approval from a wandb user to run all CI checks. To see the current diff, click here. To approve CI for this PR as of this commit, comment: |
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
itay-verkh-lightricks
changed the title
itay-verkh-lightricks
changed the title
itay-verkh-lightricks
changed the title
itay-verkh-lightricks
changed the title
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=3c89875a0f4801b74375023d529713cf7a0830d3 |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…__ on a Callable instance
Description
Fixes #3070
What does the PR do? Include a concise description of the PR contents.
Added a check for whether the given callable to
Evaluation.evaluateis a function. This prevents trying to access the__name__attribute on an instance ofModel, and the instance predict method is correctly picked byget_infer_methodTesting
Added a test in
tests/trace/test_evaluate.pythat defines a Model class with a__call__method and runs an evaluation. Validated that if I remove my fix the test fails