Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(weave): Update Not Diamond custom router to use new eval API #2664

Open
acompa opened this issue Oct 10, 2024 · 0 comments
Open

feat(weave): Update Not Diamond custom router to use new eval API #2664

acompa opened this issue Oct 10, 2024 · 0 comments

Comments

@acompa
Copy link

acompa commented Oct 10, 2024 

          This file is quite interesting. Happy to land as is, but in the near future (a few weeks), we will have a more "direct" eval API that allows users to write eval results in batch, outside of the framework loops

Originally posted by @tssweeney in #2606 (comment)

Happy to support this refactor once the new API is released, @tssweeney @andrewtruong. Thank you both for your support with this contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acompa