Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Add materialized views that will make it easier to do billing calculations #2636

Merged
merged 14 commits into from
Nov 7, 2024

Conversation

adrnswanberg
Copy link
Contributor

@adrnswanberg adrnswanberg commented Oct 8, 2024

Description

Add materialized views that provide usage stats for our major tables.

Testing

How was this PR tested?
Locally with a clickhouse server

@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 8, 2024

started_at SimpleAggregateFunction(any, Nullable(DateTime64(3))),
attributes_size_bytes SimpleAggregateFunction(any, Nullable(UInt64)),
inputs_size_bytes SimpleAggregateFunction(any, Nullable(UInt64)),
input_refs SimpleAggregateFunction(groupArrayArray, Array(String)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if you wanted to trim down the fields, but you could probably drop many of these if we just want the size stats.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

felt easier to include them..they might come in handy for quick analysis? we can always drop them later. easier to drop than include later as backfills are hard.

@adrnswanberg adrnswanberg marked this pull request as ready for review November 4, 2024 07:31
@adrnswanberg adrnswanberg requested a review from a team as a code owner November 4, 2024 07:31
@adrnswanberg
Copy link
Contributor Author

@tssweeney Finally got around to testing this -- all working ok.

@adrnswanberg adrnswanberg changed the title chore(billing): Add materialized views that will make it easier to do billing calculations chore(weave): Add materialized views that will make it easier to do billing calculations Nov 4, 2024
@adrnswanberg adrnswanberg enabled auto-merge (squash) November 7, 2024 00:37
…weave into adrian/materialized_billing_views
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the migration number (requesting changes to make sure we don't forget)

@adrnswanberg adrnswanberg disabled auto-merge November 7, 2024 06:29
@adrnswanberg adrnswanberg merged commit f83c59e into master Nov 7, 2024
74 checks passed
@adrnswanberg adrnswanberg deleted the adrian/materialized_billing_views branch November 7, 2024 06:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants