Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve :aggregators #88

Closed
myguidingstar opened this issue Apr 23, 2018 · 5 comments
Closed

Improve :aggregators #88

myguidingstar opened this issue Apr 23, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@myguidingstar
Copy link
Contributor

or check existence
@myguidingstar
Copy link
Contributor Author

myguidingstar commented May 10, 2018 •
edited
Loading 

{:joins {:artile/liked-by-count [:article/id :favorite/article-id :favorite/user-id :user/id]
;; exaggerated count by 100!!! :D
:aggregate-joins {:article/liked-by-count [:+ 100 [:count*]}}

@myguidingstar
Copy link
Contributor Author

aggregate-joins implemented in #94
Check exist is more complicated
Can't use aggregate-joins in filters yet

@myguidingstar
Copy link
Contributor Author

myguidingstar commented May 16, 2018 •
edited
Loading

Improvement to be made:

  • write doc!
  • also work with idents, not just joins
  • add find-child-aggregate-joins similar to find-child-join
  • fetch aggregate-joins first, then merge them to parent before fetching normal joins

@myguidingstar myguidingstar added this to the 1.0 milestone May 17, 2018
@myguidingstar myguidingstar changed the title a new kind of joins that only count items a new kind of joins/idents that only count items May 26, 2018
@myguidingstar myguidingstar changed the title a new kind of joins/idents that only count items Improve :aggregators Jun 1, 2018
@myguidingstar myguidingstar added documentation enhancement New feature or request and removed documentation labels Nov 21, 2018
@myguidingstar
Copy link
Contributor Author

will be part of #137

@myguidingstar myguidingstar removed this from the 1.0 milestone Feb 15, 2021
@myguidingstar
Copy link
Contributor Author

implemented except EXISTS, which has its own issue now #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@myguidingstar