Add pytest entrypoints #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial fix. * Use Guava to merge the iterables. Looks a lot cleaner. * Cleaning. * Log entrypoints. * Enhance. * Add pytest calls to methods test. * Update .gitignore. * Move to new class. * Add pytest test class with an explicit ctor. * Simply assertions.
msridhar
approved these changes
Feb 23, 2024
Comment on lines
55
to
71
| FieldReference global = | ||
| FieldReference.findOrCreate( | ||
| PythonTypes.Root, | ||
| Atom.findOrCreateUnicodeAtom( | ||
| "global " | ||
| + getMethod() | ||
| .getDeclaringClass() | ||
| .getName() | ||
| .toString() | ||
| .substring( | ||
| 1, | ||
| getMethod() | ||
| .getDeclaringClass() | ||
| .getName() | ||
| .toString() | ||
| .lastIndexOf('/'))), | ||
| PythonTypes.Root); |
There was a problem hiding this comment.
There seem to be some repeated sub-expressions here. This would be more readable if those were stored in locals.
There was a problem hiding this comment.
Sorry, I more or less copied this and adapted it from the Turtle case. I'll have a look. I admittedly don't know everything that is going on here but it seems to work well.
There was a problem hiding this comment.
Ok no worries. Just a comment on readability, I'm sure it works.
There was a problem hiding this comment.
OK I gave a it a shot.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeled after the turtle entrypoints. See http://pytest.org.