Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow subscribeToContentTopic to use other cluster IDs #1900

Open
fbarbu15 opened this issue Mar 11, 2024 · 3 comments
Open

feat: allow subscribeToContentTopic to use other cluster IDs #1900

fbarbu15 opened this issue Mar 11, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@fbarbu15
Copy link
Collaborator

This is a change request

Problem

subscribeToContentTopic starts a new node with partial ContentTopicInfo (no clusterId) so createLightNode will resolve clusterId to DEFAULT_CLUSTER_ID=1
But Autosharding will be possible on other cluster IDs as well with waku-org/nwaku#2502

Proposed Solutions

Allow clusterId as a parameter in subscribeToContentTopic
@fryorcraken fryorcraken added this to Waku Mar 11, 2024
@fbarbu15 fbarbu15 mentioned this issue Mar 13, 2024
Merged
@chair28980 chair28980 moved this to Blocked in Waku Mar 13, 2024
@chair28980
Copy link
Contributor

Blocked by waku-org/nwaku#2502

@fbarbu15
Copy link
Collaborator Author

This was fixed on nwaku side here

@chair28980 chair28980 moved this from Blocked to Triage in Waku Mar 14, 2024
@weboko weboko changed the title Allow subscribeToContentTopic to use other cluster IDs feat: allow subscribeToContentTopic to use other cluster IDs Apr 24, 2024
@weboko weboko added the enhancement New feature or request label Apr 24, 2024
@weboko
Copy link
Collaborator

weboko commented Apr 24, 2024

Moving to the top of Todo column to be taken next once release related and reliability bugs are done.

@weboko weboko moved this from Triage to To Do in Waku Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fbarbu15 @chair28980 @weboko