Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev-ex focused API to enable/disable discovery #1891

Open
danisharora099 opened this issue Mar 6, 2024 · 0 comments
Open

feat: dev-ex focused API to enable/disable discovery #1891

danisharora099 opened this issue Mar 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

Similar to work on #1871, developers currently rely on importing discovery packages and passing it to libp2p.peerDiscovery like:

import {wakuPeerExchange, wakuDnsDiscovery} from '@waku/sdk';

createLightNode({
   libp2p: {
       peerDiscovery: [wakuPeerExchange(), wakuDnsDiscovery()...]
      }
   })

Proposed Solutions

Provide an API like:

createLightNode({
      discovery: {
          peerExchange: true,
          dnsDiscovery: true,
          bootstrap: peers,
          local-cache: true,
      }
   })

Notes

@fryorcraken fryorcraken added this to Waku Mar 6, 2024
@chair28980 chair28980 added the enhancement New feature or request label Mar 6, 2024
@chair28980 chair28980 moved this to To Do in Waku Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

2 participants