Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: passing shard 0 to createEncoder will generate a pubsubtopic with shard 1 #1874

Closed
fbarbu15 opened this issue Feb 29, 2024 · 0 comments · Fixed by #1885
Closed

bug: passing shard 0 to createEncoder will generate a pubsubtopic with shard 1 #1874

fbarbu15 opened this issue Feb 29, 2024 · 0 comments · Fixed by #1885
Assignees
Labels
bug Something isn't working

Comments

@fbarbu15
Copy link
Collaborator

fbarbu15 commented Feb 29, 2024

This is a bug report

Steps

  1. ContentTopic = "/waku/2/content/test.js";
  2. singleShardInfo = { clusterId: 0, shard: 0 }
  3. encoder = createEncoder({
    contentTopic: ContentTopic,
    pubsubTopicShardInfo: singleShardInfo
    });

Generates:

Encoder {
  contentTopic: '/waku/2/content/test.js',
  ephemeral: false,
  pubsubTopic: '/waku/2/rs/0/1',
  metaSetter: undefined
}

I was expecting /waku/2/rs/0/0 since shard 0 should be valid according to https://rfc.vac.dev/spec/51//#algorithm

@fbarbu15 fbarbu15 added the bug Something isn't working label Feb 29, 2024
@fryorcraken fryorcraken added this to Waku Feb 29, 2024
@adklempner adklempner self-assigned this Mar 5, 2024
@adklempner adklempner moved this to Code Review / QA in Waku Mar 5, 2024
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants