Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test suite lacks mocking capabilities for standalone functions #1523

Closed
danisharora099 opened this issue Sep 2, 2023 · 1 comment
Closed

test suite lacks mocking capabilities for standalone functions #1523

danisharora099 opened this issue Sep 2, 2023 · 1 comment

Comments

@danisharora099
Copy link
Collaborator

danisharora099 commented Sep 2, 2023 •
edited
Loading

This is a feature request

Problem

Our current test suite comprises of Sinon for the stubbing and mocking, which seems to not work with standalone functions directly: sinonjs/sinon#562

These leads to tests failing on the added utility tests: #1469

Proposed Solutions
@fryorcraken fryorcraken added this to Waku Sep 2, 2023
This was referenced Sep 2, 2023
Open
Merged
@danisharora099
Copy link
Collaborator Author

danisharora099 commented Sep 7, 2023 •
edited
Loading

tracked with #1144

@github-project-automation github-project-automation bot moved this to Done in Waku Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danisharora099