New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter subscription improvements #1133

Open

1 of 2 tasks

chaitanyaprem opened this issue Jun 19, 2024 · 0 comments

Open

1 of 2 tasks

feat: filter subscription improvements #1133

chaitanyaprem opened this issue Jun 19, 2024 · 0 comments

Collaborator

chaitanyaprem commented Jun 19, 2024 •

edited

Loading

Problem

Some improvements in filter subscription management that can be done

Resubscribe in case of peer disconnection. Don’t wait for filter ping to fail, rather do it based on disconnection notification (Probably can be done with peerManager)
On connection loss, don’t call unsubscribe (it would anyways fail) rather close the subscriptions locally

chaitanyaprem changed the title ~~feat: Filter subscription improvements~~ feat: filter subscription improvements

fryorcraken added this to Waku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment