Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Wagtail 6.3 (and ImageBlock) #840

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Dec 18, 2024

Fixes #839

To-Do:

  • Tests

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.01%. Comparing base (caf14b8) to head (04ec5bd).

Files with missing lines Patch % Lines
wagtail_localize/segments/extract.py 81.25% 3 Missing ⚠️
wagtail_localize/models.py 66.66% 1 Missing and 1 partial ⚠️
wagtail_localize/segments/ingest.py 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   93.07%   93.01%   -0.07%     
==========================================
  Files          47       47              
  Lines        4144     4192      +48     
  Branches      704      540     -164     
==========================================
+ Hits         3857     3899      +42     
- Misses        173      177       +4     
- Partials      114      116       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerolab zerolab changed the title Add support for ImageBlock Add support for Wagtail 6.3 (and ImageBlock) Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using new ImageBlock
2 participants