-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event wall - posting issues #190
Comments
try adding public/javascripts/post.js instead of duplicating it in the html. That's in pull #219. |
I think we should consider having event extend Commentable instead of Postable, so that it would have a comment area instead of a full fledged post area. |
If we were following Facebook as the model for Events, Facebook allows for an Event to contain Posts and essentially its own news feed of actions related to that Event. Do you think it would be better to remove some of that functionality by only allowing comments instead of full posts, or would Commentable retain the majority of those features? |
Commentable won't do that, it's just comments. What I'm concerned with is code duplication across all the views of things that implement Postable. Perhaps we could pull the majority of code out of news.html and put it in some sort of wall.html tag that can be included in news, about, groups, pages, and events. |
Good idea..... hmmm yeah |
You can post empty strings.
Some funky stuff happens with javascript injection.
The text was updated successfully, but these errors were encountered: