Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event wall - posting issues #190

Open
Neji107 opened this issue Apr 18, 2012 · 5 comments
Open

Event wall - posting issues #190

Neji107 opened this issue Apr 18, 2012 · 5 comments

Comments

@Neji107
Copy link
Collaborator

Neji107 commented Apr 18, 2012

You can post empty strings.

Some funky stuff happens with javascript injection.

@ProCynic
Copy link
Collaborator

try adding public/javascripts/post.js instead of duplicating it in the html. That's in pull #219.

@ProCynic
Copy link
Collaborator

I think we should consider having event extend Commentable instead of Postable, so that it would have a comment area instead of a full fledged post area.

@melodyb
Copy link
Collaborator

melodyb commented Apr 27, 2012

If we were following Facebook as the model for Events, Facebook allows for an Event to contain Posts and essentially its own news feed of actions related to that Event. Do you think it would be better to remove some of that functionality by only allowing comments instead of full posts, or would Commentable retain the majority of those features?

@ProCynic
Copy link
Collaborator

Commentable won't do that, it's just comments. What I'm concerned with is code duplication across all the views of things that implement Postable. Perhaps we could pull the majority of code out of news.html and put it in some sort of wall.html tag that can be included in news, about, groups, pages, and events.

@amshali
Copy link
Collaborator

amshali commented Apr 27, 2012

Good idea..... hmmm yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants