-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi VM compatible Multi Signature Wallet #2369
Conversation
Hey @ashWhiteHat , |
Hey @PieWol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashWhiteHat thanks a lot for the application. In general, this sounds interesting to me. However, I have one concern here: Given that you already worked on various projects in the past (https://github.com/w3f/Grants-Program/pulls?q=is%3Apr+author%3AashWhiteHat+is%3Aclosed). Is this more of a side project or do you actually plan to focus on it and get it production ready?
Hi @Noc2 |
Hi @ashWhiteHat thanks for the application. I agree that this sounds interesting, but I'm curious about the implications of using an EVM-compatible substrate solution vs. a typical EVM smart contract multi-sig. Would it possibly introduce any performance overhead or compatibility requirements? How would you ensure that the pallet functions correctly within the substrate runtime? |
Hi @keeganquigley Firstly, the primary motivation(implication) of this proposal is to create a multi-signature wallet that supports both EVM and Wasm with a single private key. This simplifies private key management and allows for a single setup to create a multi-signature wallet for both EVM and Wasm.
Implementing equivalent functionality in EVM with Substrate's existing multi-sig support results in overhead and performance degradation.
This proposal includes the implementation of a multi-sig contract wallet for EVM. Therefore, by conducting equivalent functional tests within the Substrate runtime pallet, we can ensure its proper functionality. |
I know that they have been delivered. My concern is that they are no longer maintained or never made it to production. |
All of our pallets are ready and available for developers as we describe in our organization README. We have been working on privacy and scaling so far. This was the MTG report slide. Finally, we have changed the direction to enterprise service. I can talk about it more detail in the MTG if you would like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please elaborate on the usecase of this project? I don't quite understand what the benefit of this solution would be if you would need to set up your multi-sig on each chain with the help of the substrate pallet or the smart contracts on EVM. With this constraint the benefit to the current multi-sig landscape sounds rather minimal. Given that are wallets already that feature creating ethereum and substrate accounts from the same seed I don't see any improvement from a users perspective. The only difference I am aware of right now is that you are not using a single seed but instead a private key directly. The private key would then be in the format of whatever crypto primitive you come up with?
I'd love to hear more about this.
|
||
The Multi-Signature Wallet is structured in four key components. | ||
|
||
1. **Primitive**: This layer encompasses cryptographic libraries for core operations like elliptic curve calculations, signing algorithms, and multi-signature construction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean you will roll your own crypto? Sounds like you want to create your own crypto libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not from scratch.
We have already implemented primitives tested well so we are going to implement on top of these.
https://github.com/KogarashiNetwork#activities
This proposal aims to address the challenges faced when implementing blockchain into corporate business workflows. When setting up wallets, it is common practice to store privately generated keys locally, managed by in-house engineers or KYC providers, in cold wallets, rather than relying on seed generation from browser or app wallets. This proposal presents a multi-signature wallet designed to meet these requirements. This use case envisions a business workflow where documents and evidence, agreed upon by a consortium of corporations, can be efficiently verified by anyone in the Wasm environment, while also being stored in a legally binding manner and used for settlements on the widely adopted EVM chain.
This wallet enables the provision of corporate services leveraging the benefits of both EVM and Wasm, and we anticipate its application across various scenarios in the future. |
I fail to understand the benefit of using this solution over deriving both an EVM and substrate style account from the same seed given that you would still have to send transactions to both chains with your solution. If you would simply abstract this account derivation step from the user it would be the very same user experience, wouldn't it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashWhiteHat, thanks for the detailed reply, and sorry for the delay. I think at this point, it might be better to get funding via VCs or somebody else who also advice your projects actively and helps you with marketing and other tasks. Therefore, I'm personally not approving the application, but I will also share it again with the rest of the team. Others might still be interested in it.
The multisig featured wallets currently are not using BLS381 for substrate chains we just started supporting BLS in substrate as of just a couple months ago. I understand the need and want for more multisig solutions but we dont have any protocol based multisigs implemented yet right now all of the wallets are utilizing generally onchain multisigs or other multi sigs which just store the committees public keys and verify them one by one. |
Hi @Noc2 Hi @PieWol
This solution is mainly for corporate use cases. Hi @coax1d |
Thank you for the detailed explanation @ashWhiteHat. Considering that you confirmed my understanding of the project I'm sorry to let you know that I will not approve it. I simply don't see the need for this project as interesting as it might sound. I hope you understand that we are trying to fund impactful projects within the grants program. Let's see what my colleagues will say. Best of luck. |
Hi @ashWhiteHat I'm afraid I have to agree with @PieWol concerns above that I'm not quite convinced about the use case here. There is already a lot of development happening in the multi-sig area and imo it would be better to collaborate on an existing project. I also think that this project could be better funded by VCs, if enough corporations want something like this. Now that three have voted against it, I will go ahead and close the application. Of course, this decision has nothing to do with your work, which has been great in the past. So let us know if you have other interesting ideas you want to work on. |
Project Abstract
A Multi-Signature Wallet that is user-friendly and simplifies the management of crypto assets across both Wasm and EVM.
Grant level
Application Checklist
project_name.md
).