Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit DigiTrust proposal #2219

Closed
wants to merge 3 commits into from
Closed

Submit DigiTrust proposal #2219

wants to merge 3 commits into from

Conversation

phamdat721101
Copy link

@phamdat721101 phamdat721101 commented Feb 15, 2024 •
edited
Loading

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or Polkadot (USDC & USDT) address in the application).
  • I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. Please submit the following text as a separate comment:

I have read and hereby sign the Contributor License Agreement.

phamdat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@phamdat721101
Copy link
Author

phamdat721101 commented Feb 15, 2024 via email

keeganquigley
keeganquigley requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @phamdat721101 thanks for the application. I have the following initial comments:

  • Milestone 2 is missing delivery tables. Could you add these in?
  • We typically only focus on the PoC and therefore aren't able to fund gathering feedback or beta testing. Could you remove deliverable 5?
  • We don't support Solidity development, would you be willing to write them in ink! instead?

@keeganquigley keeganquigley added the changes requested The team needs to clarify a few things first. label Feb 16, 2024
@keeganquigley keeganquigley self-assigned this Feb 16, 2024
@phamdat721101
Copy link
Author

phamdat721101 commented Feb 17, 2024 via email

@keeganquigley
Copy link
Contributor

Thanks @phamdat721101 we usually require mandatory deliverables for all milestones, could you also add those in for M2 as well?

@phamdat721101
Copy link
Author

phamdat721101 commented Feb 17, 2024 via email

keeganquigley
keeganquigley requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phamdat721101 however I'm still not seeing deliverables 0a. - 0e. present in M2.

  1. Can you add these in? You can skip the Docker deliverable if it doesn't apply; also just one article for M2 is fine.

  2. We usually ask for mockups to be provided upfront for UI focused milestones, even if they are rough.

  3. For M2, its not clear to me how the notifications are being built.

  4. Curious why you want to use traditional email/password login? Seems like a wallet login would be sufficient seeing as its dealing with assets.

@phamdat721101
Copy link
Author

phamdat721101 commented Feb 20, 2024 via email

@keeganquigley
Copy link
Contributor

Thanks for the changes @phamdat721101 I'm still not seeing that the M2 Market News section has been elaborated upon. That being said, I will go ahead and mark your application as ready for review.

But I'm personally not convinced about it seeing as you list only EVM DeFi protocols in the tech stack and your team doesn't have much Rust/ink! expertise. Also this is a DeFi focused app that could be more appropriately funded via a VC or one of the DeFi parachain grant programs or even a community treasury, given the social aspect of it.

Therefore I won't personally approve it but I will open it up for other committee members to comment.

@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Feb 21, 2024
@phamdat721101
Copy link
Author

phamdat721101 commented Feb 22, 2024 via email

semuelle
semuelle requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your application, @phamdat721101. I agree with @keeganquigley that it's missing some technical details. See the questions below. That being said, it might make more sense to focus on a few of these deliverables, as this is a technical grants program and many of the deliverables you list are not reusable or useful to the ecosystem by themselves.

  • What parachains are you planning to deploy this on?
  • Do you have experience with ink! and Substrate?
  • "Connect with relevant APIs", "Notifications can be sent to users", "Implement real-time communication" - these are too vague to be useful or properly evaluated.

applications/DigiTrust.md

Key Achievements:

**Blockchain Integration:** Smart contracts have been deployed to testnet, providing users with transparent and tamper-resistant asset management.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which testnet is this? Can you share the addresses?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 - DigiTrust targets to deploy on Statemint parachain
2 - We are starting to work with Ink! and Substrate now, and we will migrate system from solidity base
3 - These are extra features in the second milestone, and we will explain more detail after having traffic from first-version for building portfolio management
4 - DigiTrust is deployed in Klaytn-testnet : 0xa39c2b7957496d28cd6b3fd005b4a1584abe0c30

Noc2
Noc2 requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. But why do you need to "Integrate blockchain technology" to track portfolio data? For this kind of solution no smart contract or anything similar should be needed, at least if the portfolio is based on digital assets. What kind of smart contracts have you deployed as part of your MVP?

@keeganquigley
Copy link
Contributor

pinging @phamdat721101

@phamdat721101
Copy link
Author

Thanks for the application. But why do you need to "Integrate blockchain technology" to track portfolio data? For this kind of solution no smart contract or anything similar should be needed, at least if the portfolio is based on digital assets. What kind of smart contracts have you deployed as part of your MVP?

@phamdat721101 phamdat721101 reopened this Mar 6, 2024
@phamdat721101
Copy link
Author

Thanks for the application. But why do you need to "Integrate blockchain technology" to track portfolio data? For this kind of solution no smart contract or anything similar should be needed, at least if the portfolio is based on digital assets. What kind of smart contracts have you deployed as part of your MVP?

Hi, DigiTrust target to track portfolio data as the post content for decentralized social network feature, which can support investors or managers to share their performance,
We already deployed test-version in Klaytn-testnet in 0xa39c2b7957496d28cd6b3fd005b4a1584abe0c30

@keeganquigley
Copy link
Contributor

Hi @phamdat721101 thank you for all the time and effort you put into the application and for your communication during the process.

Unfortunately, the committee unanimously decided today not to move forward with the application. This is mainly due to the concerns listed above. Since you already have all the smart contracts built and it is meant to integrate with popular EVM DeFi apps, it might make more sense to migrate the contracts to an EVM-compatible chain like Moonbeam or Astar instead of re-writing them all.

Either way, I appreciate your interest in the W3F grants program and wish you the best of luck in finding funding.

@phamdat721101
Copy link
Author

phamdat721101 commented Mar 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keeganquigley keeganquigley keeganquigley requested changes

@Noc2 Noc2 Noc2 requested changes

@semuelle semuelle semuelle requested changes

Assignees

@keeganquigley keeganquigley

Labels
admin-review This application requires a review from an admin. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phamdat721101 @keeganquigley @semuelle @Noc2