Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part #2934
Current PR changes:
Job
class.cron/StartCronJobs/
,cron/SetupCronJobs/
.JobNames
enum.JobStatus
,JobEvent
,JobKey
.Comments:
CronJob
is a part of theJob
class. The only event that makes sense is theJobEvent.Progress
event. Job chaining is something to check; that could be a reason for having other event handlers.jobFinished
event will immediately overwritejobErrored
status here https://github.com/w3f/1k-validators-be/blob/master/packages/common/src/scorekeeper/jobs/cron/SetupCronJob.ts#L63-L73Impact:
common
scorekeeper-status-ui
Potential next steps (to be discussed):
onlyHealth
flag).