From 254d007aabe8817341ea66c1576aae67e504944d Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Thu, 21 Sep 2023 12:29:27 -0700 Subject: [PATCH 1/2] Highlight that filtering all pubKeyCredParams is an error. While this is specified in the [algorithm steps][REF], it's arguably subtle and surprising and thus worth calling out. [REF]: https://w3c.github.io/webauthn/#ref-for-dom-publickeycredentialdescriptor-type%E2%91%A0 --- index.bs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/index.bs b/index.bs index 9ccb00601..eaeac7f95 100644 --- a/index.bs +++ b/index.bs @@ -3882,6 +3882,8 @@ It mirrors some fields of the {{PublicKeyCredential}} object returned by This mirrors the {{Credential/type}} field of {{PublicKeyCredential}}. + Note: if all {{PublicKeyCredentialDescriptor}} elements in {{PublicKeyCredentialRequestOptions/allowCredentials}} are ignored then that must result in an error since an empty {{PublicKeyCredentialRequestOptions/allowCredentials}} is semantically distinct. + : id :: This member contains the [=credential ID=] of the [=public key credential=] the caller is referring to. From 0b011e6c677ba2bb9f260ddba517df1724fbcab1 Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Fri, 29 Sep 2023 15:11:31 -0700 Subject: [PATCH 2/2] Update capitalisation as requested. --- index.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.bs b/index.bs index eaeac7f95..0fbd027bc 100644 --- a/index.bs +++ b/index.bs @@ -3882,7 +3882,7 @@ It mirrors some fields of the {{PublicKeyCredential}} object returned by This mirrors the {{Credential/type}} field of {{PublicKeyCredential}}. - Note: if all {{PublicKeyCredentialDescriptor}} elements in {{PublicKeyCredentialRequestOptions/allowCredentials}} are ignored then that must result in an error since an empty {{PublicKeyCredentialRequestOptions/allowCredentials}} is semantically distinct. + Note: If all {{PublicKeyCredentialDescriptor}} elements in {{PublicKeyCredentialRequestOptions/allowCredentials}} are ignored then that MUST result in an error since an empty {{PublicKeyCredentialRequestOptions/allowCredentials}} is semantically distinct. : id :: This member contains the [=credential ID=] of the [=public key credential=] the caller is referring to.