add definition of power efficient, remove battery note #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
commented
Jul 4, 2024
chrisn
reviewed
Jul 4, 2024
marcoscaceres
commented
Jul 4, 2024
Co-authored-by: Chris Needham <[email protected]>
marcoscaceres
commented
Jul 4, 2024
tidoust
approved these changes
Jul 4, 2024
marcoscaceres
commented
Jul 4, 2024
marcoscaceres
requested review from
youennf
and removed request for
Djuffin and
aboba
|
This PR raises the question of whether WebCodecs |
aboba
approved these changes
Jul 4, 2024
chrisn
reviewed
Jul 4, 2024
| efficient by default, as non-hardware-accelerated codecs can be just as | ||
| efficient, particularly with low-resolution video. User agents SHOULD | ||
| NOT take the device's power source into consideration when determining | ||
| encoding power efficiency unless the device's power source has side |
There was a problem hiding this comment.
Suggested change
| encoding power efficiency unless the device's power source has side | |
| power efficiency unless the device's power source has side |
chrisn
reviewed
Jul 4, 2024
| efficient, particularly with low-resolution video. User agents SHOULD | ||
| NOT take the device's power source into consideration when determining | ||
| encoding power efficiency unless the device's power source has side | ||
| effects such as enabling different encoding modules. |
There was a problem hiding this comment.
Suggested change
| effects such as enabling different encoding modules. | |
| effects such as enabling different encoding or decoding modules. |
Djuffin
approved these changes
Jul 9, 2024
aboba
approved these changes
Jul 9, 2024
|
@chrisn, you didn't integrate your last suggested edits to drop "encoding" and add "or decoding" where the prose was focused on encoding. Is that intended? |
|
Oops, thanks. I'll fix that. |
|
Fixed in 35e5eaa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44
Preview | Diff