Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-privileged port for webhook by default #138

Merged

Conversation

indiealexh
Copy link
Contributor

Description

Use non-privileged port for webhook by adding parameter and default value for the pod's webhook port.

Related Issues

Fixes #136

Copy link

Unit Tests and Coverage

Show Output
    suite.go:73: skipping test as strict mode is disabled, see: https://github.com/cert-manager/cert-manager/pull/1354
--- FAIL: TestRunsSuite (16.06s)
    --- FAIL: TestRunsSuite/Conformance (11.63s)
        --- FAIL: TestRunsSuite/Conformance/Basic (1.89s)
            --- FAIL: TestRunsSuite/Conformance/Basic/PresentRecord (1.89s)
        --- PASS: TestRunsSuite/Conformance/Extended (0.00s)
            --- SKIP: TestRunsSuite/Conformance/Extended/DeletingOneRecordRetainsOthers (0.00s)
FAIL
FAIL	github.com/vultr/cert-manager-webhook-vultr	16.089s
FAIL

Pusher: @indiealexh, Action: pull_request_target

@happytreees happytreees merged commit 9e84d9b into vultr:master Oct 17, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Elevated permissions required
2 participants